Review Request: Show hidden dock widgets when activated by a bookmark

[Thomas Lübking]

> On 2010-10-09 16:56:38, Thomas Lübking wrote:
> > Yes it does ;-)
> > 
> > (be aware that i wrote that "just down" - the vars/classnames might slightly differ and there're likely typos =)
> > 
> > MainWindow::setDockAsCurrentTabWidget( char docktype )
> > {
> >    QDockWidget *dock(0);
> >    switch (docktype)
> >    {
> >    case 'p': dock = playlistDock; break;
> >    case 'c': dock = contextDock; break;
> >    case 'm': dock = mediaSourcesDock; break;
> >    default: return; // invalid request
> >    }
> >    if ( !tabifiedDockWidgets(dock).isEmpty() ) // is actually tabbed
> >       tabifyDockWidget(  docks.at(docks.count()-1), dock ); // tabify moves second on top of first, either 0 or c-1 should do...
> > }

d'oooh - oc. it must be sth. like

QList<QDockWidget*> docks = tabifiedDockWidgets(dock);
if (!docks.isEmpty())
   ...

(ie. forgot to define docks ;-)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100030/#review81
-----------------------------------------------------------


On 2010-10-08 12:51:02, Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100030/
> -----------------------------------------------------------
> 
> (Updated 2010-10-08 12:51:02)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Since I have tabbed my Navigation and Context views I have to manually select the tabs every time I open a bookmark.
> In my opinion this should be done automatically.
> Unfortunately I couldn't come up with a very clean solution. But please have a look at the code yourself and share your opinion.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h b86470e 
>   src/MainWindow.cpp 54c6751 
>   src/amarokurls/ContextUrlRunner.cpp 7416fbc 
>   src/amarokurls/NavigationUrlRunner.cpp 6bb6c0b 
>   src/playlist/PlaylistViewUrlRunner.cpp 749233e 
> 
> Diff: http://git.reviewboard.kde.org/r/100030/diff
> 
> 
> Testing
> -------
> 
> I'm running amarok with this patch for many weeks now without any problems.
> 
> 
> Thanks,
> 
> Daniel
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101009/6b1f558b/attachment.htm