Review Request: Usability improvement for collection setup dialog

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100024/#review80
-----------------------------------------------------------

Ship it!


Patch works fine for me. Also the code looks clean, well documented and correct to me.

Merging into Mainline now.


- Mark


On 2010-10-06 08:08:07, James Duncan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100024/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 08:08:07)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> An improvement to the usability of the collection setup dialog,
> particularly in the inclusion and exclusion of folders under the
> 'recursive' mode.
> 
> 
> Diffs
> -----
> 
>   src/dialogs/CollectionSetup.h 457c7ca 
>   src/dialogs/CollectionSetup.cpp 0d22191 
> 
> Diff: http://git.reviewboard.kde.org/r/100024/diff
> 
> 
> Testing
> -------
> 
> Lots of testing done.  The patch passed all of my use cases and
> never forced a rescan when it wasn't necessary.
> 
> 
> Thanks,
> 
> James
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101009/c99961cd/attachment.htm