Review Request: Show hidden dock widgets when activated by a bookmark

Daniel Faust hessijames at gmail.com
Thu Oct 7 20:10:13 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100030/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Since I have tabbed my Navigation and Context views I have to manually select the tabs every time I open a bookmark.
In my opinion this should be done automatically.
Unfortunately I couldn't come up with a very clean solution. But please have a look at the code yourself and share your opinion.


Diffs
-----

  src/MainWindow.h b86470e 
  src/MainWindow.cpp 54c6751 
  src/amarokurls/ContextUrlRunner.cpp 7416fbc 
  src/amarokurls/NavigationUrlRunner.cpp 6bb6c0b 
  src/playlist/PlaylistViewUrlRunner.cpp 749233e 

Diff: http://git.reviewboard.kde.org/r/100030/diff


Testing
-------

I'm running amarok with this patch for many weeks now without any problems.


Thanks,

Daniel

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101007/89d585b4/attachment.htm 


More information about the Amarok-devel mailing list