Review Request: Add ability to hide/show menubar

[Thomas Pfeiffer]

> Okay, I will update patches, but lets firstly discuss few details:
> 
> 1. Warning dialog - all ok,
> 2. "View" or "Settings"? For me, it should be rather in "View" menu
> then in "Settings". In Amarok, everything related to appearance is in
> the View menu.

Hm. That's the old battle of internal vs. external consistency then. But maybe 
Amarok should move towards external consistency in that regard anyway. Usually 
the View menu contains settings related to the view of the actual content, not 
the interface as such.
In that manner, the current items of the View menu in Amarok are mostly edge 
cases. I'd say we should discuss this more generally.

> 3. Popup menu item - IMHO it should be always visible (independently
> on menu visibility) - the only difference is checked/unchecked menu
> item state (as it's implemented in the current version of the patch).
> 
Hm. We seem to stray from the other apps that have a hide-able menu in many 
aspects. Dolphin and Konqueror for example have the item added to the content 
area's context menu because there is no other place left if the menu is 
hidden. In Gwenview I haven't found a way to un-hide it by mouse at all (which 
is bad).
So the consistency-argument isn't as strong as I thought. I'd strongly 
recommend talking to devs/maintainers of other applications with that feature 
in order to agree on a common place for it. It poses a discoverability problem 
which could be alleviated by placing it consistently across KDE apps, but 
currently even the existing apps are inconsistent.
And while at it, it might make sense to agree on a warning dialog as well.
If you don't want to talk to them, I'd recommend just doing what Konqueror and 
Dolphin do. That way at least users who have accidentally hidden the menu in 
Konqueror or Dolphin before and found out how to show it again there can 
transfer their knowledge to Amarok, even though it's not all that well done 
imho.


> --
> Best regards,
> Valentin Pavlyuchenko
> 
>