Review Request: Remove FFmpeg dependencies from the new MusicBrainz fingerprinting by using Phonon::AudioDataOutput instead of FFmpeg directly

[Leo Franchi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100021/#review66
-----------------------------------------------------------


While I appreciate this beginning of a patch, I have a few questions:

1) Does it work? This is sort of basic and needs to be verified first :)
2) How well does it work? Daniel Dewald has a working phonon-based fingerprinter here: http://gitorious.org/amarok/amarok/merge_requests/152 but is stuck on it due to a whole host of issues, all phonon audiodataoutput related. For example:
   * crashes sometimes with phonon-xine
   * doesn't work with phonon-vlc since there's no working AudioDataOutput support implemented (IIRC?) and no one interested in fixing it
   * impossibility of getting audio data faster than the speed of playing a track makes things take wayy too long

so i really thing these should be addressed first :) also, I am sure Daniel will have some comments to make.
   

- Leo


On 2010-10-03 23:07:03, Kevin Kofler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100021/
> -----------------------------------------------------------
> 
> (Updated 2010-10-03 23:07:03)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> This patch removes FFmpeg dependencies from the new MusicBrainz fingerprinting by using Phonon::AudioDataOutput instead of FFmpeg directly.
> 
> WARNING: This version of the patch is completely untested and may not even build.
> In addition, Phonon::AudioDataOutput may not be ready for production use yet (crashes, decoding speed issues).
> You have been warned.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt baacef5 
>   src/musicbrainz/MusicDNSAudioDecoder.h 97976f6 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp eef459a 
> 
> Diff: http://git.reviewboard.kde.org/r/100021/diff
> 
> 
> Testing
> -------
> 
> None yet.
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101004/21c21763/attachment.html