Review Request: Allows compiling iPod collection on Kubuntu 10.10

[James Duncan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100012/
-----------------------------------------------------------

(Updated 2010-10-03 07:59:46.191318)


Review request for amarok.


Changes
-------

Added section to take hints from pkg-config and changed the final conditional
to a call to find_package_handle_standard_args.


Summary
-------

A packaging artifact installs the gdk-pixbuf headers at a
non-standard location.  This should allow CMake to find them on 10.10.


Diffs (updated)
-----

  CMakeLists.txt 7f5fd1d 
  cmake/modules/FindGDKPixBuf.cmake PRE-CREATION 
  cmake/modules/FindGdk.cmake 90687c1 
  src/core-impl/collections/ipodcollection/CMakeLists.txt 9973564 
  src/core-impl/collections/ipodcollection/config-gdk.h.cmake e751c03 
  src/core-impl/collections/ipodcollection/handler/IpodHandler.h 373983f 
  src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 3373b2c 

Diff: http://git.reviewboard.kde.org/r/100012/diff


Testing
-------

I can compile so far, but my system has gdk-pixbuf at the standard
location.


Thanks,

James

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101003/a835f92c/attachment-0001.htm