Review Request: Allows compiling iPod collection on Kubuntu 10.10

James Duncan james.t.duncan at gmail.com
Sat Oct 2 08:35:53 CEST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100012/
-----------------------------------------------------------

(Updated 2010-10-02 06:35:53.094896)


Review request for amarok.


Changes
-------

The earlier patches didn't work because I had not updated the names of the
variables where they are used in CMakeLists.txt under ipodcollection/ and
in IpodHandler.h/cpp.  This patch (third time's the charm?) fixes that and
resolves a couple of typo issues.


Summary
-------

A packaging artifact installs the gdk-pixbuf headers at a
non-standard location.  This should allow CMake to find them on 10.10.


Diffs (updated)
-----

  CMakeLists.txt 2a0961c 
  cmake/modules/FindGDKPixBuf.cmake PRE-CREATION 
  src/core-impl/collections/ipodcollection/CMakeLists.txt 9973564 
  src/core-impl/collections/ipodcollection/config-gdk.h.cmake e751c03 
  src/core-impl/collections/ipodcollection/handler/IpodHandler.h 373983f 
  src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 3373b2c 

Diff: http://git.reviewboard.kde.org/r/100012/diff


Testing
-------

I can compile so far, but my system has gdk-pixbuf at the standard
location.


Thanks,

James

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101002/fc82b1a6/attachment-0001.htm 


More information about the Amarok-devel mailing list