Review Request: Collection Browser should show artist names for compilations

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100010/#review54
-----------------------------------------------------------

Ship it!


Looks good to me.

- Mark


On 2010-09-30 18:47:02, Peter C. Ndikuwera wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100010/
> -----------------------------------------------------------
> 
> (Updated 2010-09-30 18:47:02)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> This fix puts Artist names in the collection browser when an album is a compilation (i.e. under "Various Artists")
> 
> Haven't hacked on amarok for some time, so though I have commit rights, I'm posting here for review.
> 
> 
> This addresses bug 252790.
>     https://bugs.kde.org/show_bug.cgi?id=252790
> 
> 
> Diffs
> -----
> 
>   src/browsers/CollectionTreeItem.cpp 10fb1fc 
> 
> Diff: http://git.reviewboard.kde.org/r/100010/diff
> 
> 
> Testing
> -------
> 
> Tested and works on my system.
> 
> 
> Thanks,
> 
> Peter C.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101001/6eb8295f/attachment.htm