Review Request: MusicBrainz and MusicDNS services support implementation

Sergey Ivanov 123kash at gmail.com
Fri Oct 1 14:08:49 CEST 2010



> On 2010-09-30 22:29:13, Leo Franchi wrote:
> > Thanks for the update. Patch didn't apply cleanly to src/CMakeLists.txt, but i fixed the conflicts. Now it doesn't compile:
> > 
> > Scanning dependencies of target amaroklib
> > [  8%] Building CXX object src/CMakeFiles/amaroklib.dir/musicbrainz/MusicBrainzTagsModel.o                                                                                                                                                                                                     
> > /home/leo/kde/src/amarok/src/musicbrainz/MusicBrainzTagsModel.cpp: In member function ‘QVariantMap MusicBrainzTagsModel::getInfo(Meta::TrackPtr)’:                                                                                                                                             
> > /home/leo/kde/src/amarok/src/musicbrainz/MusicBrainzTagsModel.cpp:414:94: error: no matching function for call to ‘QMap<QString, QVariant>::insert(const QString&, QStringBuilder<char [25], QString>)’
> > /home/leo/qt/4.7/include/QtCore/qmap.h:556:51: note: candidate is: QMap<Key, T>::iterator QMap<Key, T>::insert(const Key&, const T&) [with Key = QString, T = QVariant]
> > make[2]: *** [src/CMakeFiles/amaroklib.dir/musicbrainz/MusicBrainzTagsModel.o] Error 1
> > make[1]: *** [src/CMakeFiles/amaroklib.dir/all] Error 2
> >

I was too tired and (I don't know how was it happened) filled up very old parch revision, I'm sorry. The new one is under this post. 


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100000/#review47
-----------------------------------------------------------


On 2010-10-01 12:06:12, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100000/
> -----------------------------------------------------------
> 
> (Updated 2010-10-01 12:06:12)
> 
> 
> Review request for amarok.
> 
> 
> Summary
> -------
> 
> MusicBrainz and MusicDNS services support implementation.
> There are three independent parts:
> 1. MusicBrainzFinder class - used to make requests to MusicBrainz server and process replies. All relies process in separate threads by MusicBrainzXmlParser class. For a search uses guessed from a file name track information.  No external dependences required.
> 2. MusicDNSFinder class - used for the same purpose as MusicBrainzFinder, but i communicate with musicdns server and receives track's PUID as a reply. Replies ether process in separate threads by MusicDNSXmlParser class. Fingerprints generated by libofa (the only external dependence in entire patch). For track decompressing (MusicDNSAudioDecoder class) used xine engine (I'm not sure is It a good choice, but amarok based on phonon media-engine, that uses xine. So we don't deed to pull any other dependences). Received PUIDs sends to MusicBrainzFinder class, for a search routine.
> 3. View. All classes used for store (MusicBrainzTagsModel, MusicBrainzTrackListModel) and display (MusicBrainzTagsModelDelegate) purposes.
> 
> 
> Diffs
> -----
> 
>   .gitignore 0b2885a 
>   CMakeLists.txt 2a0961c 
>   cmake/modules/FindFFmpeg.cmake PRE-CREATION 
>   cmake/modules/FindLibOFA.cmake PRE-CREATION 
>   config-amarok.h.cmake 981b7b7 
>   src/CMakeLists.txt ac5db9f 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.h 6e15303 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 8205d45 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h e35b57f 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp 9be62d9 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 8bdbf75 
>   src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp b5cb083 
>   src/core-impl/collections/sqlcollection/SqlMeta.h ee3ec21 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp 2da0333 
>   src/core-impl/meta/file/File.h 6d4d395 
>   src/core-impl/meta/file/File.cpp 30cd2ff 
>   src/core-impl/meta/file/TagLibUtils.cpp 15b64a4 
>   src/core-impl/meta/proxy/MetaProxy.h 2ef3805 
>   src/core-impl/meta/proxy/MetaProxy.cpp 341e076 
>   src/core/capabilities/EditCapability.h 79344bd 
>   src/dialogs/MusicBrainzTagger.h PRE-CREATION 
>   src/dialogs/MusicBrainzTagger.cpp PRE-CREATION 
>   src/dialogs/MusicBrainzTagger.ui PRE-CREATION 
>   src/dialogs/TagDialog.h 50cd801 
>   src/dialogs/TagDialog.cpp 26d4eb8 
>   src/dialogs/TagDialogBase.ui 9974d0b 
>   src/musicbrainz/MusicBrainzFinder.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzFinder.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzMetaClasses.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzMetaClasses.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzTagsModel.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzTagsModel.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzTrackListModel.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzTrackListModel.cpp PRE-CREATION 
>   src/musicbrainz/MusicBrainzXmlParser.h PRE-CREATION 
>   src/musicbrainz/MusicBrainzXmlParser.cpp PRE-CREATION 
>   src/musicbrainz/MusicDNSAudioDecoder.h PRE-CREATION 
>   src/musicbrainz/MusicDNSAudioDecoder.cpp PRE-CREATION 
>   src/musicbrainz/MusicDNSFinder.h PRE-CREATION 
>   src/musicbrainz/MusicDNSFinder.cpp PRE-CREATION 
>   src/musicbrainz/MusicDNSXmlParser.h PRE-CREATION 
>   src/musicbrainz/MusicDNSXmlParser.cpp PRE-CREATION 
>   tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp 55d1914 
> 
> Diff: http://git.reviewboard.kde.org/r/100000/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101001/d3d2e306/attachment-0001.htm 


More information about the Amarok-devel mailing list