Review Request: Fetch cover for DAAP Albums #240060

[Andy Coder]

> On 2010-11-30 17:39:15, Ian Monroe wrote:
> > Does DAAP not have images available?

[0] seems to indicate that Firefly Media Server doesn't keep track of album art, and [1] makes no mention of images that can be obtained through DAAP.  If there's a documented way to fetch the art from a DAAP server, it's at least a little hard to find.

[0] - http://wiki.fireflymediaserver.org/DB_Fields
[1] - http://tapjam.net/daap/


- Andy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100176/#review446
-----------------------------------------------------------


On 2010-11-28 15:03:30, Dennis Francis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100176/
> -----------------------------------------------------------
> 
> (Updated 2010-11-28 15:03:30)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This is just a copy and paste attempt to introduce cover fetch functionality for DAAP albums. I used PlaydarMeta.h/.cpp as the reference.
> 
> Please suggest better methods !
> 
> The cover arts does not persists between multiple runs of amarok; it seems to load the art from internet everytime. Should I be using ServiceAlbumCoverDownloader which has implemented caching ?
> 
> 
> This addresses bug 240060.
>     https://bugs.kde.org/show_bug.cgi?id=240060
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/daap/DaapMeta.h 8187d1e 
>   src/core-impl/collections/daap/DaapMeta.cpp 61aa0db 
> 
> Diff: http://git.reviewboard.kde.org/r/100176/diff
> 
> 
> Testing
> -------
> 
> I am using a firefly DAAP server. 
> Cover art is getting fetched in non-blocking mode.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101130/ccc5b88a/attachment.htm