Review Request: Playlist Queue Editor

[Andreas Hartmetz]

> On 2010-11-29 22:53:02, Leo Franchi wrote:
> > Looks good to me now! I'd just shrink it a bit more.. the ratio is still fine, but the dialog is still quite large. There's room for 50+ queued tracks,that seems like overkill....

Pushed, thanks. (With a slightly smaller dialog)


- Andreas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100177/#review442
-----------------------------------------------------------


On 2010-11-29 18:11:59, Andreas Hartmetz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100177/
> -----------------------------------------------------------
> 
> (Updated 2010-11-29 18:11:59)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This adds a Queue Editor, with limited features (move up / move down / clear) like in Amarok 1.
> The KAction for it is not very well placed in the main UI, I hope you guys can help me.
> A few design changes were necessary, too, as you can see in the patch.
> 
> 
> This addresses bug 198180.
>     https://bugs.kde.org/show_bug.cgi?id=198180
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c5ee1e3 
>   src/MainWindow.cpp f755b6f 
>   src/likeback/LikeBackBar.cpp 6964f88 
>   src/playlist/PlaylistActions.h a0b2275 
>   src/playlist/PlaylistActions.cpp d9284e7 
>   src/playlist/PlaylistController.cpp f05c250 
>   src/playlist/PlaylistDock.h f7f1231 
>   src/playlist/PlaylistDock.cpp 6170f78 
>   src/playlist/PlaylistItem.h 6bfeb68 
>   src/playlist/PlaylistModel.h 7b7633f 
>   src/playlist/PlaylistModel.cpp 0162321 
>   src/playlist/PlaylistQueueEditor.h PRE-CREATION 
>   src/playlist/PlaylistQueueEditor.cpp PRE-CREATION 
>   src/playlist/PlaylistQueueEditor.ui PRE-CREATION 
>   src/playlist/navigators/DynamicTrackNavigator.cpp a1c67e7 
>   src/playlist/navigators/StandardTrackNavigator.cpp faeb9f7 
>   src/playlist/navigators/TrackNavigator.h 6154f9a 
>   src/playlist/navigators/TrackNavigator.cpp 2a70b08 
>   src/playlist/proxymodels/AbstractModel.h 03ca4d6 
>   src/playlist/proxymodels/ProxyBase.h 2e6f9e7 
>   src/playlist/proxymodels/ProxyBase.cpp 37cb8cb 
>   src/playlist/view/PlaylistViewCommon.cpp 2a5c9f6 
>   src/playlist/view/listview/PrettyItemDelegate.cpp 5494279 
>   src/playlist/view/listview/PrettyListView.cpp 0b2e41e 
>   src/statusbar/StatusBar.cpp 1a67677 
> 
> Diff: http://git.reviewboard.kde.org/r/100177/diff
> 
> 
> Testing
> -------
> 
> "worksforme"
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101129/e64b83aa/attachment.html