Review Request: Implements the wishlist item 185397 - "Saved playlist default name could be smarter"

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100168/#review440
-----------------------------------------------------------

Ship it!


I integrated the patch but did change a few lines:
1) Added copyright info since the generateName function is non-trivial.
2) Removed the date from the single artist, single album case.
3) Fixed some potential i18n issues.

Thanks for the great work, keep these patches coming, they are really good and improved amarok a lot.
Bart

- Bart


On 2010-11-26 11:37:58, Dennis Francis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100168/
> -----------------------------------------------------------
> 
> (Updated 2010-11-26 11:37:58)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The playlist name is generated as per the rules :
> 
>     if ( singleArtist && singleAlbum )
>         playlistName = artist + " - " + album + ' - ' + shortDate
> 
>     else if ( !singleArtist && singleAlbum )
>         playlistName = "Various" + " - " + album + ' - ' + shortDate
> 
>     else if ( singleArtist && !singleAlbum )
>         playlistName = artist + " - " + "Various" + shortDate
> 
>     else
>         playlistName = "Various" + " - " + shortDate
> 
> If the there are no tracks, the playlist name is set to "Empty Playlist - " + shortDate
> 
> 
> This addresses bug 185397.
>     https://bugs.kde.org/show_bug.cgi?id=185397
> 
> 
> Diffs
> -----
> 
>   src/playlist/PlaylistDock.cpp f781528 
>   src/playlist/PlaylistModel.h 7b7633f 
>   src/playlist/PlaylistModel.cpp 0162321 
> 
> Diff: http://git.reviewboard.kde.org/r/100168/diff
> 
> 
> Testing
> -------
> 
> Tested different possibilities. It is working fine for me.
> 
> Please suggest better alternatives ( if any ) to the shortDate addition. Without the shortDate, playlist database lookup would be necessary to 
> calculate a unique name.
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101129/de356c1d/attachment.htm