Review Request: Playlist Queue Editor

Leo Franchi lfranchi at kde.org
Mon Nov 29 02:04:33 CET 2010



> On 2010-11-28 23:46:36, Leo Franchi wrote:
> > Ok, a few comments from using it. Here are issues I think need to be addressed:
> > 
> > * I think the action should be centered like the other actions below the playlist, probable with a separator.
> > * I think the default size of the dialog is too big, especially given how small the items are
> > * Lacking icon for 3rd/bottom button
> > * The list is sort of lacking. It should at least show the Artist as well, maybe like Artist - Title.
> > * List doesn't update on track progression, but jumps ahead once a button is pressed and tracks have progressed
> > * Dialog is modal---it shouldn't be, so the user can also add/remove stuff from the queue with the queue manager open. Hand in hand with this is the fact that the playlist should update to reflect any changes made in the dialog immediately
> > 
> > And these are issues I think are nice but not required for version 1:
> > 
> > * Tracks should be re-arrangable by drag-n-drop
> > * Tracks from the playlist should be draggable onto the Queue Manager to queue them at a specific place
> > 
> > cheers,
> > leo
> 
> Andreas Hartmetz wrote:
>     * Listview item text with too little information: fixedName() looked like it would change the least, but I think you're right: displaying useful information in the common case is more important. Queueing streams that often have no defined end is not a common thing to do.
>     * List not updating on track progression: I expected the queueChanged() signal from the playlist because track progression effectively dequeues a track. I'll try to fix it in the playlist.
>     * Modality: Intentional so the playlist doesn't change too much while the dialog exists, possibly causing bugs. I expect that one would usually click on items in the playlist to enqueue them - you will likely discover them there with no dialog open (because it's just annoying to have another window you don't need most of the time). Then you edit the queue. I don't use dynamic playlist though, so if the playlist can change anyway while the dialog is up it could as well be non-modal.
>     * Updating the playlist: this probably means emitting the right signal at the right place. Any ideas?

Yeah, I think we should optimize for the "usual" use-case of tracks in the playlist. You bring up a good point, as it is super easy to modify the playlist so severely that the queue dialog would basically be reset. so about the modality....hm. In general I think modal dialogs are bad and need a very good reason to be modal---stopping the user from interacting with amarok until he finishes the "queue stuff in the queue manager" action is quite severe. say the user opens the queue manager, changes around the queues a bit and is around halfway there. then the track changes, but the user wants to skip it or something--he has to exit the queue manager (with his partially-completed queue) and and do that, then open the queue manager again. Ok, so this is somewhat obscure. Maybe it depends on how complicated it'll be to keep the manager in sync with the playlist :D

I don't really know about dynamic mode: i've never tried dynamic mode + queueing, as they are almost cross-purpose, so i don't think we should be doing too much work to support that configuration. you get weird behaviours with the dynamic track progression if you suddenly start playing stuff out of order anyway.

hmm, I don't know much about the playlist connection stuff, sorry. you know more than I do now about the playlist :)


- Leo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100177/#review436
-----------------------------------------------------------


On 2010-11-29 00:00:22, Andreas Hartmetz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100177/
> -----------------------------------------------------------
> 
> (Updated 2010-11-29 00:00:22)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This adds a Queue Editor, with limited features (move up / move down / clear) like in Amarok 1.
> The KAction for it is not very well placed in the main UI, I hope you guys can help me.
> A few design changes were necessary, too, as you can see in the patch.
> 
> 
> This addresses bug 198180.
>     https://bugs.kde.org/show_bug.cgi?id=198180
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt c5ee1e3 
>   src/MainWindow.cpp f755b6f 
>   src/likeback/LikeBackBar.cpp 6964f88 
>   src/playlist/PlaylistActions.h a0b2275 
>   src/playlist/PlaylistActions.cpp d9284e7 
>   src/playlist/PlaylistController.cpp f05c250 
>   src/playlist/PlaylistDock.h f7f1231 
>   src/playlist/PlaylistDock.cpp 6170f78 
>   src/playlist/PlaylistItem.h 6bfeb68 
>   src/playlist/PlaylistModel.h 7b7633f 
>   src/playlist/PlaylistModel.cpp 0162321 
>   src/playlist/PlaylistQueueEditor.h PRE-CREATION 
>   src/playlist/PlaylistQueueEditor.cpp PRE-CREATION 
>   src/playlist/PlaylistQueueEditor.ui PRE-CREATION 
>   src/playlist/navigators/DynamicTrackNavigator.cpp a1c67e7 
>   src/playlist/navigators/TrackNavigator.h 6154f9a 
>   src/playlist/navigators/TrackNavigator.cpp 2a70b08 
>   src/playlist/proxymodels/AbstractModel.h 03ca4d6 
>   src/playlist/proxymodels/ProxyBase.h 2e6f9e7 
>   src/playlist/proxymodels/ProxyBase.cpp 37cb8cb 
>   src/playlist/view/PlaylistViewCommon.cpp 2a5c9f6 
>   src/playlist/view/listview/PrettyItemDelegate.cpp 5494279 
>   src/playlist/view/listview/PrettyListView.cpp 0b2e41e 
>   src/statusbar/StatusBar.cpp 1a67677 
> 
> Diff: http://git.reviewboard.kde.org/r/100177/diff
> 
> 
> Testing
> -------
> 
> "worksforme"
> 
> 
> Thanks,
> 
> Andreas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101129/52256623/attachment-0001.htm 


More information about the Amarok-devel mailing list