Review Request: Use MetaQueryWidget in the advanced playlist generator.

[Ralf Engels]

> On 2010-11-27 23:09:11, Alexander Potashev wrote:
> > src/core/meta/support/MetaConstants.cpp, line 120
> > <http://git.reviewboard.kde.org/r/100070/diff/5/?file=3392#file3392line120>
> >
> >     You can't use spaces in these strings, because it's impossible for the parser to guess where you have a keyword "added to collection", or you have a string "added to" and a keyword "collection", etc...

ok. that's easy to change.


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100070/#review425
-----------------------------------------------------------


On 2010-11-07 19:06:34, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100070/
> -----------------------------------------------------------
> 
> (Updated 2010-11-07 19:06:34)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Instead of implementing the whole behavior of selecting field and values I am just using the MetaQueryWidget.
> 
> Also I am moving all field related texts to src/core/meta/support/MetaConstants.cpp
> This would also be a good place for the playlist to get it's texts from.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 2160670 
>   src/core-impl/collections/support/XmlQueryReader.h 0088608 
>   src/core-impl/collections/support/XmlQueryReader.cpp b5518f0 
>   src/core-impl/collections/support/XmlQueryWriter.h 5caf7bc 
>   src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 
>   src/core/CMakeLists.txt 8272804 
>   src/core/meta/support/MetaConstants.h 73d03fc 
>   src/core/meta/support/MetaConstants.cpp PRE-CREATION 
>   src/core/meta/support/MetaUtility.h 47e7c24 
>   src/core/meta/support/MetaUtility.cpp 5cf4519 
>   src/dynamic/Bias.h 082327c 
>   src/dynamic/Bias.cpp 8a8ab97 
>   src/playlistgenerator/PresetModel.cpp 9b74636 
>   src/playlistgenerator/constraints/PlaylistDuration.h 992215c 
>   src/playlistgenerator/constraints/PlaylistDuration.cpp 5d83dfe 
>   src/playlistgenerator/constraints/TagMatch.h f23d562 
>   src/playlistgenerator/constraints/TagMatch.cpp d8ed7db 
>   src/playlistgenerator/constraints/TagMatchComparer.cpp PRE-CREATION 
>   src/playlistgenerator/constraints/TagMatchEditWidget.ui b9d97c6 
>   src/playlistgenerator/constraints/TagMatchSupport.cpp 6b777b1 
>   src/widgets/MetaQueryWidget.h ba64e4c 
>   src/widgets/MetaQueryWidget.cpp 32f3f24 
> 
> Diff: http://git.reviewboard.kde.org/r/100070/diff
> 
> 
> Testing
> -------
> 
> Generated several advanced playlists testing a couple of the fields and all the conditions.
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101128/b2b06161/attachment.htm