Review Request: Fetch cover for DAAP Albums #240060

[Dennis Francis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100176/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

This is just a copy and paste attempt to introduce cover fetch functionality for DAAP albums. I used PlaydarMeta.h/.cpp as the reference.

Please suggest better methods !

The cover arts does not persists between multiple runs of amarok; it seems to load the art from internet everytime. Should I be using ServiceAlbumCoverDownloader which has implemented caching ?


This addresses bug 240060.
    https://bugs.kde.org/show_bug.cgi?id=240060


Diffs
-----

  src/core-impl/collections/daap/DaapMeta.h 8187d1e 
  src/core-impl/collections/daap/DaapMeta.cpp 61aa0db 

Diff: http://git.reviewboard.kde.org/r/100176/diff


Testing
-------

I am using a firefly DAAP server. 
Cover art is getting fetched in non-blocking mode.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101128/d0522a6b/attachment.htm