Review Request: Merge tag reading and writing into one file.

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100169/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Move the slightly different code for tag reading and writing into one file.
Benefit:
- amarok collection scanner and Meta::FileTrack will behave the same.
- easier to keep reading and writing in sync
- less code to maintain

 20 files changed, 1424 insertions(+), 3137 deletions(-)


Diffs
-----

  shared/MetaTagLib.h PRE-CREATION 
  shared/MetaTagLib.cpp PRE-CREATION 
  shared/MetaValues.h PRE-CREATION 
  src/CMakeLists.txt 3a0ac94 
  src/core-impl/collections/db/DatabaseMeta.cpp d19bc5b 
  src/core-impl/collections/db/sql/CMakeLists.txt 2b82b2b 
  src/core-impl/collections/db/sql/SqlMeta.cpp 5ababa0 
  src/core-impl/meta/file/File.h f620767 
  src/core-impl/meta/file/File.cpp b66bd25 
  src/core-impl/meta/file/File_p.h 443cf27 
  src/core-impl/meta/file/TagLibUtils.h 9d0fd8c 
  src/core-impl/meta/file/TagLibUtils.cpp ea72626 
  src/core/meta/support/MetaConstants.h b63e530 
  tests/core-impl/collections/sqlcollection/CMakeLists.txt 7627c41 
  tests/core-impl/collections/sqlcollection/TestSqlQueryMaker.cpp eb2d5db 
  tests/mocks/AftUtilityMock.cpp 2ff92d3 
  utilities/collectionscanner/AFTUtility.h b211569 
  utilities/collectionscanner/AFTUtility.cpp 85e2364 
  utilities/collectionscanner/CMakeLists.txt a368981 
  utilities/collectionscanner/Track.h 47434ff 
  utilities/collectionscanner/Track.cpp 0df0b7d 

Diff: http://git.reviewboard.kde.org/r/100169/diff


Testing
-------

Auto tests and collection scanner.


Thanks,

Ralf

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101125/8b1349bf/attachment-0001.htm