Review Request: Fixes bugs 250746, 250750 and partially fixes bug 245646

[Dennis Francis]

> On 2010-11-20 08:08:37, Nikhil Shantanu Marathe wrote:
> > Using indices to select actions is not very future proof. If actions are re-ordered or removed this code would have to be changed or it could have potentially tragic consequences. The action name is usually a unique identifier. Afaik the Playlist actions generated from a PlaylistProvider::playlistActions() do not have names. So perhaps you could assign names to them and use those names to choose the right action. Make sure when you fetch the action by name, the action is non-null.

By name of an action, do you mean the text attribute of QAction ?


- Dennis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100158/#review366
-----------------------------------------------------------


On 2010-11-20 11:20:27, Dennis Francis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100158/
> -----------------------------------------------------------
> 
> (Updated 2010-11-20 11:20:27)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch fixes the bug 250746 which causes a crash while using 'delete' key to delete multiple playlists.
> When multiple playlists are selected and deleted using delete key, only the first one in the selectedIndexes() gets row removed properly. 
> 
> I used an alternative route to fix the issue, by using actionsFor() method for getting the actions for the selected
> indexes(selected playlists) and then triggering the last action of the returned ActionList (The last action was found to be the one corresponds to
> row remove operation).
> 
> QTreeView is expanded to depth 0. This resolves 'delete key press' version of bug 245646. Context menu version of this bug can
> also be resolved in a similar way through another patch.
> 
> Further, this patch automatically fixes bug 250750 - "Cancel delete of playlist initialised by 'Delete' key not clean". Now when you press cancel,
> none of the playlists are touched.
> 
> 
> This addresses bugs 250746 and 250750.
>     https://bugs.kde.org/show_bug.cgi?id=250746
>     https://bugs.kde.org/show_bug.cgi?id=250750
> 
> 
> Diffs
> -----
> 
>   src/browsers/playlistbrowser/PlaylistBrowserView.cpp 2603e2f 
> 
> Diff: http://git.reviewboard.kde.org/r/100158/diff
> 
> 
> Testing
> -------
> 
> Tested with different possible selection patterns using "CTRL+click". Delete key press deletes only the selected playlists when confirmed, else none of
> them are affected. The PlayListBrowserView maintains the same expanded state after deletion.
> Things seems to work fine for me. 
> 
> 
> Thanks,
> 
> Dennis
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101120/70e8f60e/attachment.htm