Review Request: Album Artist. Further support improvements

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100135/#review339
-----------------------------------------------------------


Regarding the noCompilation of the collection scanner.
Actually this makes sense.

The collection scanner has a lot of heuristics for detecting if an album is a compilation.
However we also have a compilation tag.
If the tag claims that a track is definitely not in a compilation, then we should respect this and not try to auto-detect the compilation status.

I just noticed that I was not following this rule myself, but neighter should the noCompilation variable be removed unless you can argue why this doesn't make sense.


- Ralf


On 2010-11-14 22:37:15, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100135/
> -----------------------------------------------------------
> 
> (Updated 2010-11-14 22:37:15)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add new QueryType - AlbumArtist.
> Add new "level" to collection browser.
> Add Album Artist field to TagDialog.
> Add Album Artist to TagGuesser and Organize Collection dialog.
> Tiny changes to collection scanner: simplify albumartist handling for Album class, and remove really strange (and mostly useless) m_isNoCompilation var from Track.
> 
> 
> Diffs
> -----
> 
>   src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 
>   src/amarokurls/NavigationUrlRunner.cpp 2d6384b 
>   src/browsers/CollectionTreeItemModelBase.h 23a189f 
>   src/browsers/CollectionTreeItemModelBase.cpp 7015cd4 
>   src/browsers/CollectionTreeView.cpp 2bb894c 
>   src/browsers/collectionbrowser/CollectionWidget.cpp 8623079 
>   src/core-impl/collections/db/sql/SqlMeta.cpp 1d70872 
>   src/core-impl/collections/db/sql/SqlQueryMaker.h 680050f 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 
>   src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 72cd07d 
>   src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h 63d6c2c 
>   src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp c17c3fd 
>   src/core-impl/collections/support/MemoryQueryMaker.h 72ddaf1 
>   src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 
>   src/core-impl/collections/support/MemoryQueryMakerInternal.h db94d8b 
>   src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 
>   src/core-impl/collections/support/XmlQueryReader.cpp b5518f0 
>   src/core-impl/collections/support/XmlQueryWriter.h 5caf7bc 
>   src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 
>   src/core/collections/MetaQueryMaker.h 799825a 
>   src/core/collections/MetaQueryMaker.cpp 10ae2a7 
>   src/core/collections/QueryMaker.h 9c15659 
>   src/core/collections/QueryMaker.cpp 78c6ba7 
>   src/core/meta/support/MetaConstants.h ba56248 
>   src/core/meta/support/MetaUtility.cpp 5cf4519 
>   src/dialogs/FilenameLayoutDialog.h 2e20c77 
>   src/dialogs/FilenameLayoutDialog.cpp 9b572a9 
>   src/dialogs/FilenameLayoutDialog.ui b65b6f1 
>   src/dialogs/MusicBrainzTagger.cpp a9fc8a2 
>   src/dialogs/TagDialog.h fbc89ae 
>   src/dialogs/TagDialog.cpp ddd73cb 
>   src/dialogs/TagDialogBase.ui 816ecb5 
>   src/dialogs/TagGuesser.h 476b16d 
>   src/dialogs/TagGuesser.cpp bd3820d 
>   src/services/ServiceSqlQueryMaker.h 5591ecc 
>   src/services/ServiceSqlQueryMaker.cpp 197f2cf 
>   src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 
>   src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 4dc8fed 
>   src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 
>   utilities/collectionscanner/Album.h a22b3bd 
>   utilities/collectionscanner/Album.cpp 74e8081 
>   utilities/collectionscanner/Directory.cpp 848f2b3 
>   utilities/collectionscanner/Track.h 47434ff 
>   utilities/collectionscanner/Track.cpp ab2c2b5 
> 
> Diff: http://git.reviewboard.kde.org/r/100135/diff
> 
> 
> Testing
> -------
> 
> Tested with SqlCollection. Seems works for me. 
> 
> 
> Screenshots
> -----------
> 
> Only one album "Once". As It should be.
>   http://git.reviewboard.kde.org/r/100135/s/17/
> 2 albums, and 3rd is somewhere below.
>   http://git.reviewboard.kde.org/r/100135/s/18/
> 
>   http://git.reviewboard.kde.org/r/100135/s/19/
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101115/4c25ed83/attachment-0001.htm