Review Request: Album Artist for QueryMaker

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100135/#review334
-----------------------------------------------------------

Ship it!


Looks very sensible to me.
I haven't run the code but it looks very good all around.

- Ralf


On 2010-11-10 19:35:59, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100135/
> -----------------------------------------------------------
> 
> (Updated 2010-11-10 19:35:59)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Add new QueryType - AlbumArtist. Add new "level" to collection browser.
> It works well with SqlCollection, still need to make It work for all services which support such queries.
> 
> 
> Diffs
> -----
> 
>   src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 
>   src/amarokurls/NavigationUrlRunner.cpp 2d6384b 
>   src/browsers/CollectionTreeItemModelBase.h 23a189f 
>   src/browsers/CollectionTreeItemModelBase.cpp 280245a 
>   src/browsers/CollectionTreeView.cpp 2bb894c 
>   src/browsers/collectionbrowser/CollectionWidget.cpp 8623079 
>   src/core-impl/collections/db/sql/SqlQueryMaker.h 680050f 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 
>   src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 9002acf 
>   src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.h 63d6c2c 
>   src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp c17c3fd 
>   src/core-impl/collections/support/MemoryQueryMaker.h 72ddaf1 
>   src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 
>   src/core-impl/collections/support/MemoryQueryMakerInternal.h db94d8b 
>   src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 
>   src/core-impl/collections/support/XmlQueryReader.cpp b5518f0 
>   src/core-impl/collections/support/XmlQueryWriter.h 5caf7bc 
>   src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 
>   src/core/collections/MetaQueryMaker.h 799825a 
>   src/core/collections/MetaQueryMaker.cpp 10ae2a7 
>   src/core/collections/QueryMaker.h 9c15659 
>   src/core/collections/QueryMaker.cpp 78c6ba7 
>   src/core/meta/support/MetaConstants.h 73d03fc 
>   src/core/meta/support/MetaUtility.cpp 5cf4519 
>   src/dialogs/TagDialog.h fbc89ae 
>   src/dialogs/TagDialog.cpp ddd73cb 
>   src/dialogs/TagDialogBase.ui 816ecb5 
>   src/services/ServiceSqlQueryMaker.h 5591ecc 
>   src/services/ServiceSqlQueryMaker.cpp 197f2cf 
>   src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 
>   src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp 4dc8fed 
>   src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 
> 
> Diff: http://git.reviewboard.kde.org/r/100135/diff
> 
> 
> Testing
> -------
> 
> Tested with SqlCollection. Seems works for me. 
> 
> 
> Screenshots
> -----------
> 
> Only one album "Once". As It should be.
>   http://git.reviewboard.kde.org/r/100135/s/17/
> 2 albums, and 3rd is somewhere below.
>   http://git.reviewboard.kde.org/r/100135/s/18/
> 
>   http://git.reviewboard.kde.org/r/100135/s/19/
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101111/e5f5fa8b/attachment.htm