Review Request: Album Artist for QueryMaker

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100135/
-----------------------------------------------------------

(Updated 2010-11-06 19:58:32.908609)


Review request for Amarok.


Summary
-------

Add new QueryType - AlbumArtist. Add new "level" to collection browser.
It works well with SqlCollection, still need to make It work for all services which support such queries.


Diffs
-----

  src/amarokurls/NavigationUrlGenerator.cpp 5c48e73 
  src/amarokurls/NavigationUrlRunner.cpp 2d6384b 
  src/browsers/CollectionTreeItemModelBase.h 23a189f 
  src/browsers/CollectionTreeItemModelBase.cpp 280245a 
  src/browsers/collectionbrowser/CollectionWidget.cpp f493a5e 
  src/core-impl/collections/db/sql/SqlQueryMaker.cpp ca105e8 
  src/core-impl/collections/db/sql/SqlQueryMakerInternal.cpp 9002acf 
  src/core-impl/collections/proxycollection/ProxyCollectionQueryMaker.cpp c17c3fd 
  src/core-impl/collections/support/MemoryQueryMaker.cpp 81bf9b6 
  src/core-impl/collections/support/MemoryQueryMakerInternal.cpp eeffd77 
  src/core-impl/collections/support/XmlQueryWriter.cpp 3c9cf41 
  src/core/collections/QueryMaker.h 9c15659 
  src/services/ServiceSqlQueryMaker.cpp 197f2cf 
  src/services/ampache/AmpacheServiceQueryMaker.cpp 7dee8c8 
  src/services/scriptable/ScriptableServiceQueryMaker.cpp 76faca2 

Diff: http://git.reviewboard.kde.org/r/100135/diff


Testing
-------

Tested with SqlCollection. Seems works for me. 


Screenshots
-----------

Only one album "Once". As It should be.
  http://git.reviewboard.kde.org/r/100135/s/17/
2 albums, and 3rd is somewhere below.
  http://git.reviewboard.kde.org/r/100135/s/18/


Thanks,

Sergey

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101106/346768e7/attachment.htm