Review Request: Helper Methods for FileType Enum in new Class FileTypeSupport, get Type in TagDialog from Database instead of Extension, some Code Changes as Example of the Advantage of the Helper Methods

[Stefan Derkits]

> On 2010-11-05 20:18:22, Sergey Ivanov wrote:
> > src/widgets/MetaQueryWidget.cpp, line 594
> > <http://git.reviewboard.kde.org/r/100088/diff/7/?file=3259#file3259line594>
> >
> >     And you will add "Other" to this Combobox.
> >     I guess you should start loop from 1 again. :)

Nope ... that is intended ... at least as long as we don't have (nearly) every possible FileType as enum in FileType.h ... this way you can search for other formats then the rest in the list


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100088/#review306
-----------------------------------------------------------


On 2010-11-05 19:48:36, Stefan Derkits wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100088/
> -----------------------------------------------------------
> 
> (Updated 2010-11-05 19:48:36)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> -) Created new Class with some Helper Functions
> -) Changed MetaQueryWidget to use the QStringList that contains all Filetypes
> -) Meta::SqlTrack.type() now gets it's Information from the Database instead of the FileExtension
> 
> 
> Diffs
> -----
> 
>   shared/FileType.h 55c80b9 
>   shared/FileType.cpp PRE-CREATION 
>   src/CMakeLists.txt b114bcd 
>   src/browsers/CollectionTreeItemModelBase.cpp 3f64a73 
>   src/core-impl/collections/db/sql/CMakeLists.txt 858f5c3 
>   src/core-impl/collections/db/sql/SqlMeta.h f1ee131 
>   src/core-impl/collections/db/sql/SqlMeta.cpp 006c805 
>   src/core-impl/collections/support/MemoryFilter.cpp e2509ac 
>   src/widgets/MetaQueryWidget.cpp 0249edf 
>   tests/synchronization/CMakeLists.txt e5df2df 
>   utilities/collectionscanner/CMakeLists.txt 22f3f1c 
>   utilities/collectionscanner/Track.cpp 9291662 
> 
> Diff: http://git.reviewboard.kde.org/r/100088/diff
> 
> 
> Testing
> -------
> 
> Tested in the App, found no wrong Behaviour
> 
> 
> Thanks,
> 
> Stefan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101105/056c3afb/attachment.htm