Review Request: Coverbling applet (playground) build fix

[Alex Merry]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100133/#review302
-----------------------------------------------------------

Ship it!


Looks good (modulo my code style comment below).


playground/src/context/applets/coverbling/CoverBlingApplet.cpp
<http://git.reviewboard.kde.org/r/100133/#comment247>

    Code style: there should be a space after m_autojump.
    
    Actually, you could put
    if ( !m_autojump )
      return
    as the first line of the method, before querying the current track, but that doesn't really matter.


- Alex


On 2010-11-05 15:59:22, Manu Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100133/
> -----------------------------------------------------------
> 
> (Updated 2010-11-05 15:59:22)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This fixes CoverBling applet build (broken since yesterday's delivery).
> 
> 
> Diffs
> -----
> 
>   playground/src/context/applets/coverbling/CoverBlingApplet.h 5ffc8b8 
>   playground/src/context/applets/coverbling/CoverBlingApplet.cpp d5ac4df 
> 
> Diff: http://git.reviewboard.kde.org/r/100133/diff
> 
> 
> Testing
> -------
> 
> It works fine at my end.
> Compiles and runs OK
> 
> 
> Thanks,
> 
> Manu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101105/b81ebf39/attachment.htm