Review Request: Coverbling applet (playground) build fix

[Manu Wagner]

> On 2010-11-04 19:28:30, Alex Merry wrote:
> > playground/src/context/applets/coverbling/CoverBlingApplet.cpp, lines 164-166
> > <http://git.reviewboard.kde.org/r/100133/diff/1/?file=3216#file3216line164>
> >
> >     What happens when the value of m_autojump is changed?

well you're right.
if it started with m_autojump off, it will not call jumpToPlaying() ever.
I should remove this "if", provided that jumpToPlaying handles both cases (m_autojump on/off)
I'll submit a new patch asap


- Manu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100133/#review292
-----------------------------------------------------------


On 2010-11-04 18:39:02, Manu Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100133/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 18:39:02)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This fixes CoverBling applet build (broken since yesterday's delivery).
> 
> 
> Diffs
> -----
> 
>   playground/src/context/applets/coverbling/CoverBlingApplet.cpp d5ac4df 
>   playground/src/context/applets/coverbling/CoverBlingApplet.h 5ffc8b8 
> 
> Diff: http://git.reviewboard.kde.org/r/100133/diff
> 
> 
> Testing
> -------
> 
> It works fine at my end.
> Compiles and runs OK
> 
> 
> Thanks,
> 
> Manu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101105/856277f2/attachment.htm