Review Request: Permit the use of iPod touch 3G (and upper?) with Amarok

Ian Monroe ian.monroe at gmail.com
Thu Nov 4 17:57:46 CET 2010



> On 2010-11-04 16:18:16, Ian Monroe wrote:
> > src/MediaDeviceCache.cpp, line 218
> > <http://git.reviewboard.kde.org/r/100132/diff/1/?file=3179#file3179line218>
> >
> >     Maybe a comment here explaining why iPods shouldn't use the following codepath.

Oh and it should be QLatin1Literal("iPod")


- Ian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100132/#review287
-----------------------------------------------------------


On 2010-11-04 14:14:36, Aurélien Croc wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100132/
> -----------------------------------------------------------
> 
> (Updated 2010-11-04 14:14:36)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Permit the use of ipod touch 3G (and upper?) with Amarok.
> 
> Once an ipod touch 3G is connected to the computer it is recognized by Amarok and mounted (by using ifuse).
> 
> 
> Diffs
> -----
> 
>   src/MediaDeviceCache.cpp 429f314 
>   src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp 2507cb7 
> 
> Diff: http://git.reviewboard.kde.org/r/100132/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101104/3b5e9621/attachment.htm 


More information about the Amarok-devel mailing list