Review Request: Fixes for TagUtility. Turn back MPC files support. Tiny fix of album change handler in SqlTrack.
Sergey Ivanov
123kash at gmail.com
Wed Nov 3 23:16:57 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100129/
-----------------------------------------------------------
(Updated 2010-11-03 22:16:57.537555)
Review request for Amarok.
Changes
-------
Move absolutely all fields modification code to replaceField function ( It become huge. I hate id3 tags :( ).
Summary
-------
Rewrite a bit TagUtility, and turn back MPC files support.
Diffs (updated)
-----
src/core-impl/collections/db/sql/SqlMeta.cpp 3943a1f
src/core-impl/meta/file/File_p.h 3dd38a4
src/core-impl/meta/file/TagLibUtils.cpp 6eb9f60
Diff: http://git.reviewboard.kde.org/r/100129/diff
Testing
-------
Tested on mp3, flac and mp4 files. Unit-test also passed.
Thanks,
Sergey
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101103/f6653355/attachment.htm
More information about the Amarok-devel
mailing list