Review Request: Refactoring. Year is now an int and createDate an uint in Meta.

[Ralf Engels]

> On 2010-10-31 16:52:44, Leo Franchi wrote:
> > look okay to me, will test with it in a bit.
> 
> Maximilian Kossick wrote:
>     Definitely not ship it. We should move all return types to QDateTime instead of the uint which is a left over form A1, instead of removing the one place where it is actually done properly.

Also fine with me.
At least it's type safe this way.


- Ralf


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100119/#review233
-----------------------------------------------------------


On 2010-10-31 14:57:41, Ralf Engels wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100119/
> -----------------------------------------------------------
> 
> (Updated 2010-10-31 14:57:41)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Changes all instances of setYear( QString ) to setYear( int ) for better type safety.
> Changes all instances of QDateTime Meta::Track::createDate() to uint Meta::Track::createDate() for better consistency with the other track dates which are already uints.
> 
> 
> Diffs
> -----
> 
>   src/browsers/CollectionTreeItemModelBase.cpp c25549b 
>   src/context/applets/albums/AlbumsModel.cpp 9b376ff 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.h 286cb3f 
>   src/core-impl/capabilities/timecode/TimecodeEditCapability.cpp 9a69079 
>   src/core-impl/collections/audiocd/AudioCdMeta.h d5bb5a7 
>   src/core-impl/collections/audiocd/AudioCdMeta.cpp 4255d00 
>   src/core-impl/collections/daap/DaapMeta.h dcbb6ae 
>   src/core-impl/collections/daap/DaapMeta.cpp b8389b7 
>   src/core-impl/collections/daap/daapreader/Reader.h 5c21caf 
>   src/core-impl/collections/daap/daapreader/Reader.cpp 0fd70e5 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.h 7df9225 
>   src/core-impl/collections/mediadevicecollection/MediaDeviceMeta.cpp f3142e1 
>   src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp 98fb5ba 
>   src/core-impl/collections/playdarcollection/PlaydarCollection.cpp 0520e8d 
>   src/core-impl/collections/playdarcollection/PlaydarMeta.h e14d4d5 
>   src/core-impl/collections/playdarcollection/PlaydarMeta.cpp 7b3f302 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.h 9fe8ef6 
>   src/core-impl/collections/proxycollection/ProxyCollectionMeta.cpp 2008336 
>   src/core-impl/collections/sqlcollection/ArtistHelper.cpp 1430df6 
>   src/core-impl/collections/sqlcollection/CapabilityDelegateImpl.cpp 0e3578a 
>   src/core-impl/collections/sqlcollection/SqlMeta.h afdf937 
>   src/core-impl/collections/sqlcollection/SqlMeta.cpp b1a0694 
>   src/core-impl/collections/support/MemoryCollection.h 2d5eebb 
>   src/core-impl/collections/support/MemoryFilter.cpp c076494 
>   src/core-impl/collections/support/MemoryMatcher.cpp bfcbd82 
>   src/core-impl/collections/umscollection/handler/UmsHandler.cpp 1a5d2bb 
>   src/core-impl/collections/umscollection/podcasts/UmsPodcastMeta.h 0f3b72d 
>   src/core-impl/collections/umscollection/podcasts/UmsPodcastMeta.cpp 80a9523 
>   src/core-impl/collections/upnpcollection/UpnpMeta.cpp 81bfa04 
>   src/core-impl/meta/file/File.h 9ab364b 
>   src/core-impl/meta/file/File.cpp 70f2b91 
>   src/core-impl/meta/file/File_p.h e1af28e 
>   src/core-impl/meta/proxy/MetaProxy.h 3bae966 
>   src/core-impl/meta/proxy/MetaProxy.cpp 450cd6e 
>   src/core-impl/meta/proxy/MetaProxy_p.h c581271 
>   src/core-impl/meta/stream/Stream.h cb45d3b 
>   src/core-impl/meta/stream/Stream.cpp c688053 
>   src/core-impl/meta/timecode/TimecodeMeta.h 6fb0caa 
>   src/core-impl/meta/timecode/TimecodeMeta.cpp 470283e 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp 9a5b656 
>   src/core/capabilities/EditCapability.h ba91ef9 
>   src/core/collections/Collection.h a085f32 
>   src/core/meta/Meta.h 35a4dc0 
>   src/core/meta/Meta.cpp e9c5089 
>   src/core/meta/support/MetaUtility.cpp 534a61a 
>   src/dialogs/TagDialog.cpp f0e671a 
>   src/dynamic/Bias.cpp 6934a70 
>   src/playlist/view/listview/PrettyItemDelegate.cpp ab19ccc 
>   src/playlistgenerator/constraints/TagMatch.cpp a719825 
>   src/scriptengine/MetaTypeExporter.h fd9c96c 
>   src/scriptengine/MetaTypeExporter.cpp 19e226e 
>   src/services/ServiceMetaBase.h 72a7115 
>   src/services/ServiceMetaBase.cpp d267ade 
>   src/services/mp3tunes/Mp3tunesServiceCollection.cpp 304f147 
>   src/services/mp3tunes/Mp3tunesServiceQueryMaker.cpp df6e47f 
>   tests/core-impl/collections/proxycollection/TestProxyCollectionMeta.cpp 97e0281 
>   tests/core-impl/collections/sqlcollection/TestSqlTrack.cpp c4fa045 
>   tests/core-impl/meta/file/TestMetaFileTrack.cpp c921981 
>   tests/mocks/MetaMock.h d3c820c 
>   tests/mocks/MockTrack.h b799704 
> 
> Diff: http://git.reviewboard.kde.org/r/100119/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ralf
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101101/f7cca1fd/attachment.htm