[Amarok] 366dbe7 Fix SqlTrack playcount semantics towards LastFM/FM

Jeff Mitchell mitchell at kde.org
Wed Mar 24 16:45:36 CET 2010


On 3/24/2010 11:40 AM, Maximilian Kossick wrote:
> Yes, the other place would be StatisticsProvider.
> 
> 
> If it does not know about the lenght of the track yet, it needs to be
> added (ideally by just delegating the call from Track to
> StatisticsProvider instead of just forwarding it)

By delegating do you mean moving finishedPlaying out of Track and into
StatisticsProvider (which may impact other cleanup processes and may
cause issues for e.g. proxycollection)? Or removing playcount logic from
finishedPlaying, and follow up finishedPlaying with e.g. an
updateStatistics call (containing the length of the track and the played
fraction)? Or...?

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100324/095397f3/attachment.sig 


More information about the Amarok-devel mailing list