Switching playcount increment time

[Jeff Mitchell]

On 3/17/2010 3:21 AM, Maximilian Kossick wrote:
> On Tue, Mar 16, 2010 at 11:18 PM, Jeff Mitchell <mitchell at kde.org> wrote:
>> On 3/16/2010 5:08 PM, Maximilian Kossick wrote:
>>> How does this affect last.fm scrobbling though? Scrobbling should not
>>> use Meta::Track::finsihedPlaying() but simply use the time between two
>>> EngineController metadata changes.
>>
>> It doesn't; as I said it breaks Last.fm scrobbling *semantics*.
>>
>> Last.fm scrobbling semantics say that a track should be scrobbled when
>> either half the song or the first four minutes have been played,
>> whichever comes first. When the track is shorter than 30 seconds, it is
>> not scrobbled.
> 
> Scrobbling works completely independent from the Amarok-internal
> update of statistics. It does not depend on any logic implemented in
> finishedPlaying().

Again. I didn't say it breaks Last.fm scrobbling. I said it breaks
Last.fm scrobbling *semantics*.

>> I believe that these are relatively sane rules, with the exception that
>> if a track is shorter than 30 seconds, the entire track should be
>> played. Granted, we were not perfectly adhering to these rules before,
>> but the way it has been changed now can certainly lead to tracks being
>> "played" when the user is simply trying to skip around.
>>
>> I'll update this.
> 
> Sure go ahead. But keep in mind that it has to be implemented in at
> least two places.

Where is/are the other place(s)?

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 196 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100317/5df9450a/attachment.sig