Switching playcount increment time

[Maximilian Kossick]

On Tue, Mar 16, 2010 at 9:28 PM, Jeff Mitchell <mitchell at kde.org> wrote:
> Max,
>
> In commit 1f92c6a4fb40e3885ca29783e1bc4add644305a5 you stated:
>
> "increase playcount immediatly instead of only after half the song has
> been played. The latter can take a while for long tracks. This should
> probably be discussed, but at least this way it seems to be handled
> consistently in Amarok."
>
> Is there a reason that you did this without discussion first, as opposed
> to suggesting that there should be a discussion later?
>
> Not only does this break Last.fm scrobbling semantics (and semantics of
> the upcoming FMPS spec/integration) but it's not a very sane value as it
> means that simply skipping past songs that you don't want to hear could
> trigger an increase in playcount if they play for a tiny amount of time.
>
> Thanks,
> Jeff
>

I changed it because I noticed it. Feel free to change to another
consistent approach.

How does this affect last.fm scrobbling though? Scrobbling should not
use Meta::Track::finsihedPlaying() but simply use the time between two
EngineController metadata changes.

Cheers,
Max