New experimental toolbar by Thomas Luebking

Thomas Lübking thomas.luebking at web.de
Fri Jan 29 15:53:34 CET 2010


Am Friday 29 January 2010 schrieb Mark Kretschmann:

> Thanks for the update :) Can we merge this now into mainline?

- I've just recomitted the svg (req. v5 - there was a "comic" frame around 
some of the icons - not in inkscape, but when rendered in amarok. don't ask me 
how it got there ;-)
I guess we'll have to double check it after the merge (the svg caused 
unresolvable merge errors here nearby every time)

- Also I _seriously_ recommand a second verifcation of the various 
TrackNavigators (esp. as i changed the RandonTrack navi alot)
(I chcked them, but there should imho at least be a 2nd source)

Btw, the Repeat&Random Album navis apparently fail outside the local 
collection. (in vanialla amarok as well)
I noticed that during the first work on them, but forgot about it and figured 
again ;-)

- Whoever handles promotion should comment on the promo srting before the next 
freeze then (though we can of course still just disable it entirely)
 
> PS:
> We can give you direct push access to the Amarok Git repository, if
> you want to continue working on it, after merging.
Thanks, this would probably be helpfull (so you don't have to review "changed 
geometry aspects by 0.5%" merge requests ;-)
I promise to of course ask before I introduce major functionality changes.

Cheers,
Thomas


More information about the Amarok-devel mailing list