[Amarok] Hopefully fix some crashes caused by weird stuff i

[Maximilian Kossick]

On Sat, Jan 9, 2010 at 6:18 PM, Jeff Mitchell <mitchell at kde.org> wrote:
> On 01/09/2010 12:02 PM, Maximilian Kossick wrote:
>> I'd like to ask for a "no commits to code that has unit tests without
>> running those" policy, please
>
> The code I wrote doesn't have unit tests. You added those after (this is
> code against v2.2.2 tag). This is simply forward-porting that commit,
> and since it was cherry-picked it was automated. We can fix it afterward
> if unit tests show problems.
>
It did from the point that I committed them.

> And besides, I don't know how to run them.  :-)
>

set CMAKE_BUILD_TYPE = "debugfull" and KDE4_BUILD_TESTS=ON in cmake.

then run make test, or use ctest

> _______________________________________________
> Amarok-devel mailing list
> Amarok-devel at kde.org
> https://mail.kde.org/mailman/listinfo/amarok-devel
>
>