2.2.2 tagging

[Mark Kretschmann]

On Mon, Jan 4, 2010 at 9:57 AM, Mark Kretschmann <kretschmann at kde.org> wrote:
> On Sun, Jan 3, 2010 at 6:10 PM, Lydia Pintscher <lydia at kde.org> wrote:
>> 2.2.2 tagging is supposed to happen in 2 days. Is everything ready for
>> that? Any known problems?
>> Everyone please have a look at the 3 remaining show stoppers on bugs.kde.org.
>
> My personal nemesis is this one:
>
> https://bugs.kde.org/show_bug.cgi?id=220994
>
>
> The funny (sad?) thing is, this bug has been around since 2.2.1, and
> it is pretty nasty. But noone ever reported it, so I guess we were
> lucky.
>
> At any rate, it's my code so I feel a bit responsible for that, and
> I'll try to fix it up before tagging. I'm still not quite sure what
> the actual root of the bug is (apparently the toolbar width is
> calculated incorrectly), but I plan to fix this up for good, using
> real Qt layout management. Still, if anyone has an idea what's going
> on there, I'd love to hear it.

So, realistically I don't think that we can fix this before 2.2.2
tagging. And meh, while I find that bug somewhat nasty, noone ever
reported it, and it only happens in certain situations. As far as I
can tell we are dealing with some sort of Qt bug here, but what
exactly that is, beats me.

I propose to fix that up properly for 2.2.3, cause I don't want to
commit half finished code now, and then it all fails or something. For
2.2.3 I also have some other ideas for making this nicer, like scaling
our buttons depending on the display DPI, which should make them look
better on wide-screen displays.


I've removed the "release_blocker" keyword from the report, and I have
set the target to 2.2.3.

-- 
Mark Kretschmann
Amarok Developer
Fellow of the Free Software Foundation Europe
www.kde.org - amarok.kde.org - www.fsfe.org