The unit tests architecture

[Ian Monroe]

On Mon, Feb 1, 2010 at 10:10 AM, Ian Monroe <ian.monroe at gmail.com> wrote:
> On Sat, Jan 30, 2010 at 8:30 PM, Nathan Sala <sala.nathan at gmail.com> wrote:
>>
>>
>> 2010/1/31 Ian Monroe <ian.monroe at gmail.com>
>>>
>>> On Sat, Jan 30, 2010 at 7:50 AM, Nathan Sala <sala.nathan at gmail.com>
>>> wrote:
>>> > Thank you Leo,
>>> >
>>> > This code is really helpful for us!
>>> >
>>> > Anyway, are some people willing to comment a global unit tests
>>> > system refactoring in Amarok?
>>> >
>>>
>>> What do you mean?
>>>
>>> The unit test code is currently quite broken, it doesn't even compile
>>> under linux. :/ But I'm not sure it needs a 'refactor'... it just
>>> needs to be fixed and have tests added to it.
>>
>> What do you mean "broken"? I can compile and run unit tests under Linux.
>
> I meant what I said, it didn't compile for me last I tried. I'll try
> it again later today.

I just tried it, and after fixing an issue that would only happen with
clean builds (that fix is pushed now), I get the following link
errors:
Linking CXX executable ../testcollectionlocation
CMakeFiles/testcollectionlocation.dir/__/__/src/meta/Meta.o: In
function `Meta::Album::image(int)':
/home/ian/srcs/amarok/src/meta/Meta.cpp:421: undefined reference to
`Amarok::saveLocation(QString const&)'
CMakeFiles/testcollectionlocation.dir/__/__/src/meta/Meta.o: In
function `Meta::Album::imageWithBorder(int, int)':
/home/ian/srcs/amarok/src/meta/Meta.cpp:458: undefined reference to
`The::svgHandler()'
/home/ian/srcs/amarok/src/meta/Meta.cpp:458: undefined reference to
`SvgHandler::addBordersToPixmap(QPixmap, int, QString const&, bool)'

Do you have local edits that allow you to build? You should send that
patch over if you do. :)

Ian