Review Request: Filter Editor Dialog "restyling"

[Sergey Ivanov]

> On 2010-12-27 21:29:39, Ralf Engels wrote:
> > I am a little bit concerned about how easy it is to understand.
> > 
> > The main usecase would be to create a filter for just one type.
> > So how difficult is it to do that now?
> > 
> > Also the line with the different filter types at the top. The icons make it very huge and you still have to scroll it.
> > That's a point that I didn't like with the playlist style dialog.
> > Maybe we can find a better solution for that.
> > A normal combo box would probably work.

Take desired token (drag It to DropTarget - field below tokensPool) and click on It. It require more steps then now, but It gives more functionality, and usually you search by some text attribute (like title, artist etc.) so you don't need FilterEditor at all.
Token's icons have the same size as on FileNameLayout (TagGuesser/OrgonizeCollection), there is no any problems to make them smaller.


- Sergey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100250/#review630
-----------------------------------------------------------


On 2010-12-27 12:58:32, Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100250/
> -----------------------------------------------------------
> 
> (Updated 2010-12-27 12:58:32)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Polish "a bit" filter editor dialog, now It uses tokens as TagGuesser dialog does, and works exactly as Editor, not just like "appender" (260333 bug).
> 
> 
> This addresses bug 260333.
>     https://bugs.kde.org/show_bug.cgi?id=260333
> 
> 
> Diffs
> -----
> 
>   src/core/meta/support/MetaConstants.cpp e2e11a9 
>   src/dialogs/EditFilterDialog.h 12088bc 
>   src/dialogs/EditFilterDialog.cpp 67f1f6e 
>   src/dialogs/EditFilterDialog.ui 4b2bf3e 
>   src/images/icons/hi48-action-filename-and-amarok.png PRE-CREATION 
>   src/widgets/MetaQueryWidget.h 9c1181a 
>   src/widgets/MetaQueryWidget.cpp 8868106 
>   src/widgets/Token.h 134184f 
>   src/widgets/Token.cpp b672121 
>   src/widgets/TokenDropTarget.cpp c454fd4 
>   src/widgets/TokenPool.cpp 41d462d 
>   src/widgets/TokenWithLayout.h 744113e 
>   src/widgets/TokenWithLayout.cpp 4f581d8 
> 
> Diff: http://git.reviewboard.kde.org/r/100250/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/100250/s/30/
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101227/e396015c/attachment-0001.htm