Review Request: Fixed Organize Files Dialog to allow for loading presets when in advanced mode

Sergey Ivanov 123kash at gmail.com
Mon Dec 27 09:41:35 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100244/#review619
-----------------------------------------------------------

Ship it!


Looks good.

- Sergey


On 2010-12-25 21:34:18, Philipp Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100244/
> -----------------------------------------------------------
> 
> (Updated 2010-12-25 21:34:18)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Simply adding a switch to the setScheme() function to not parse the given scheme but to simply set it in the according lineEdit when in advanced mode and else do the parsing for the token widget fixes the problem.
> 
> 
> This addresses bug 255325.
>     https://bugs.kde.org/show_bug.cgi?id=255325
> 
> 
> Diffs
> -----
> 
>   ChangeLog 7343431 
>   src/dialogs/FilenameLayoutDialog.cpp 97b9253 
> 
> Diff: http://git.reviewboard.kde.org/r/100244/diff
> 
> 
> Testing
> -------
> 
> Preview is updated according to the selected preset, I also moved a set of files successfully after changing the preset.
> 
> 
> Thanks,
> 
> Philipp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101227/88411b81/attachment.htm 


More information about the Amarok-devel mailing list