Review Request: "store statistics to file" should not include "rating" - only the play-changing statistics. Rating should be saved along with other tags normally.
Sergey Ivanov
123kash at gmail.com
Mon Dec 27 09:16:07 CET 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100231/#review618
-----------------------------------------------------------
Ship it!
Looks good.
- Sergey
On 2010-12-21 17:04:14, Alan Ezust wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100231/
> -----------------------------------------------------------
>
> (Updated 2010-12-21 17:04:14)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> Change the definition of the option 'store statistics to file' so that it does not include Rating.
>
> https://bugs.kde.org/show_bug.cgi?id=259117
>
>
> This addresses bug 259117.
> https://bugs.kde.org/show_bug.cgi?id=259117
>
>
> Diffs
> -----
>
> shared/MetaTagLib.cpp 3f7e758
> src/dialogs/CollectionSetup.cpp 0e4839f
>
> Diff: http://git.reviewboard.kde.org/r/100231/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alan
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101227/f1431663/attachment.htm
More information about the Amarok-devel
mailing list