Review Request: Possible fix for issues with Audio CDs that do not have CDDB information.

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100212/#review558
-----------------------------------------------------------

Ship it!


Makes sense to me.

I don't really use Audio CD's, and the same is true for many of our developers (afaik), so I guess that you might actually have more expertize on this than we have ;)

One question: Do we have an existing bug report for this somewhere?

- Mark


On 2010-12-14 17:55:03, Andriy Gapon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100212/
> -----------------------------------------------------------
> 
> (Updated 2010-12-14 17:55:03)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> When "Information/CDDB Information.txt" synthetic file is empty fallback to noInfoAvailable() approach.
> 
> 
> This addresses bug 257818.
>     https://bugs.kde.org/show_bug.cgi?id=257818
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/audiocd/AudioCdCollection.cpp 6c45edc 
> 
> Diff: http://git.reviewboard.kde.org/r/100212/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andriy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101216/55f531a1/attachment-0001.htm