Preventing scripts blocking Amarok - any taker?

Myriam Schweingruber myriam at kde.org
Thu Dec 16 12:22:06 CET 2010


Hi all,

it happens sometimes that a 3rd-party script is running wild and
blocks Amarok. Mark already started to write a mockup checking if a
script takes too long that should suggest killing it when it stalls.
The string already is prepared here:

src/dialogs/ScriptManager.cpp line 609

//MOCKUP method, see API docs
void
ScriptManager::showScriptStalledDialog()  // SLOT
{
    const QString script = "FIXME";

    const int reply = KMessageBox::questionYesNo( 0, i18n( "The script
'%1' appears to have stalled.\n\n"
                                                           "Would you
like to stop it?", script ),
                                                           i18n(
"Script Manager - Amarok" ),

KStandardGuiItem::yes(),

KStandardGuiItem::no(),
                                                           QString(),

KMessageBox::Dangerous );
    Q_UNUSED(reply)
}


Mark being very busy at the moment with his day job it would be nice
if somebody could give this the final push. The string is already in,
so this would not cause a string change and can still be committed for
2.4


Regards, Myriam.

-- 
Protect your freedom and join the Fellowship of FSFE:
http://www.fsfe.org
Please don't send me proprietary file formats,
use ISO standard ODF instead (ISO/IEC 26300)


More information about the Amarok-devel mailing list