Amarok build failure on armel for Kubuntu

[Mark Kretschmann]

On Thu, Dec 9, 2010 at 6:06 PM, Thomas Lübking
<thomas.luebking at gmail.com> wrote:
> Am Thursday 09 December 2010 schrieb Bart Cerneels:
>> const qreal addLabelProxyWidth = qMin( size().width() - 2 *
>> standardPadding(), 300.0 );
>>
>> The literal 300.0 gets treated as a double by the compiler it seems.
> Yes, as supposed to be.... (300.0f is float, qreal is no POD)
>
>> To me that suggests a compiler bug
> No, the problem is that qreal is double on all architechtures except for ARM,
> where it's defined float. (imho a debatable decision)
> Since qMin/qMax are template functions they cannot autocast, so yes:
>
>> const qreal addLabelProxyWidth = qMin( size().width() - 2 *
>> standardPadding(), (qreal)300.0 );
> this is actually the (or rather one) correct solution.

Hmm, is the fix in Git Master already? I lost track...

-- 
Mark Kretschmann
Amarok Developer, Software Engineer at KO GmbH
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://fsfe.org - http://kogmbh.com