Amarok build failure on armel for Kubuntu

[Bart Cerneels]

On Thu, Dec 9, 2010 at 16:41, Scott Kitterman <ubuntu at kitterman.com> wrote:
> markey sent asked me to write this list to mention to one of the other amarok
> developers that we have a problem on Kubuntu that because qreal != double on
> armel amarok won't build at the moment on that arch.
>
> http://launchpadlibrarian.net/60331043/buildlog_ubuntu-natty-
> armel.amarok_2:2.3.90-0ubuntu1_FAILEDTOBUILD.txt.
>
> The relvant error is:
>
> [ 69%] Building CXX object
> src/context/applets/labels/CMakeFiles/amarok_context_applet_labels.dir/LabelsApplet.o
> cd src/context/applets/labels && /usr/bin/c++   -
> DMAKE_AMAROK_CONTEXT_APPLET_LABELS_LIB -D_BSD_SOURCE -D_XOPEN_SOURCE=500 -
> D_BSD_SOURCE -DQT_NO_STL -DQT_NO_CAST_TO_ASCII -D_REENTRANT -
> DKDE_DEPRECATED_WARNINGS -DKDE4_CMAKE_TOPLEVEL_DIR_LENGTH=13 -
> DQT_USE_FAST_CONCATENATION -DQT_USE_FAST_OPERATOR_PLUS -DQT_STRICT_ITERATORS -
> g -O2  -fmessage-length=0 -Wl,--as-needed -Wnon-virtual-dtor -Wno-long-long -
> ansi -Wundef -Wcast-align -Wchar-subscripts -Wall -W -Wpointer-arith -Wformat-
> security -fno-exceptions -DQT_NO_EXCEPTIONS -fno-check-new -fno-common -
> Werror=return-type -Woverloaded-virtual -fno-threadsafe-statics -
> fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG -DQT_NO_DEBUG -fPIC -
> I. -I../../../../../src/context/applets/labels -I../../../../../shared -
> I../../../../.. -I../../../.. -
> I../../../../../src/context/applets/labels/../.. -
> I../../../../../src/context/applets/labels/../../.. -
> I/usr/include/libindicate-qt -I/usr/include/KDE -I/usr/include/qt4/phonon -
> I/usr/include/qt4/QtXmlPatterns -I/usr/include/qt4/QtXml -
> I/usr/include/qt4/QtWebKit -I/usr/include/qt4/QtUiTools -
> I/usr/include/qt4/QtTest -I/usr/include/qt4/QtSvg -I/usr/include/qt4/QtSql -
> I/usr/include/qt4/QtScriptTools -I/usr/include/qt4/QtScript -
> I/usr/include/qt4/QtOpenGL -I/usr/include/qt4/QtNetwork -
> I/usr/include/qt4/QtHelp -I/usr/include/qt4/QtDesigner -
> I/usr/include/qt4/QtDeclarative -I/usr/include/qt4/QtDBus -
> I/usr/include/qt4/Qt3Support -I/usr/include/qt4/QtGui -
> I/usr/include/qt4/QtCore -I/usr/include/qt4/Qt -
> I/usr/share/qt4/mkspecs/default -I/usr/include/qt4 -I/usr/include/taglib   -
> D_GNU_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -
> I/usr/include/taglib -I/usr/include/taglib-extras -o
> CMakeFiles/amarok_context_applet_labels.dir/LabelsApplet.o -c
> ../../../../../src/context/applets/labels/LabelsApplet.cpp
> ../../../../../src/context/applets/labels/LabelsApplet.cpp: In member function
> 'virtual void LabelsApplet::constraintsEvent(Plasma::Constraints)':
> ../../../../../src/context/applets/labels/LabelsApplet.cpp:442:94: error: no
> matching function for call to 'qMin(qreal, double)'
>
> Scott K
>
> P.S. I'm not subscribed, so please CC me on any replies.

Here is the error line:

const qreal addLabelProxyWidth = qMin( size().width() - 2 *
standardPadding(), 300.0 );

The literal 300.0 gets treated as a double by the compiler it seems.
To me that suggests a compiler bug but for now we might get away with
casting it to a qreal:
const qreal addLabelProxyWidth = qMin( size().width() - 2 *
standardPadding(), (qreal)300.0 );

Bart