Review Request: Save selected tracks to already saved playlist or a new playlist

[Dennis Francis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100181/
-----------------------------------------------------------

(Updated 2010-12-06 14:07:09.677883)


Review request for Amarok.


Changes
-------

Removed the context menu items.
Playlist::Dock::slotSaveCurrentPlaylist() saves the selected tracks.

I haven't removed the update() code from the patch as it is useful when
a save() is attempted with a name which is already there.
This is because names generated by generatePlaylistName() 
are not unique.

Fixed a small count-playlist issue in PlaylistBrowserModel::data()


Summary
-------

Added functionality in the context menu to save the selected tracks ( on the right side ) 

- to a new playlist ( currently only sqlplaylist and fileplaylist providers are only supported )
- into an already existing playlist
  ( Duplication is avoided hence feels like a playlist update )


This addresses bugs 186545, 211811 and 239950.
    https://bugs.kde.org/show_bug.cgi?id=186545
    https://bugs.kde.org/show_bug.cgi?id=211811
    https://bugs.kde.org/show_bug.cgi?id=239950


Diffs (updated)
-----

  src/browsers/playlistbrowser/PlaylistBrowserModel.cpp 34d84d9 
  src/browsers/playlistbrowser/UserPlaylistModel.cpp 2178d27 
  src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.h e1ae132 
  src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp 12d3b46 
  src/core-impl/playlists/providers/user/UserPlaylistProvider.h 609e1a8 
  src/core/playlists/PlaylistFormat.h b93180d 
  src/core/playlists/PlaylistFormat.cpp 6b3cb6b 
  src/core/playlists/PlaylistProvider.h 4cc3417 
  src/core/playlists/PlaylistProvider.cpp 2d37e8b 
  src/playlist/PlaylistDock.cpp d512b28 
  src/playlist/PlaylistModel.h 3ad8030 
  src/playlist/PlaylistModel.cpp 1acbc9f 
  src/playlistmanager/PlaylistManager.h 943fcf1 
  src/playlistmanager/PlaylistManager.cpp fb13ea7 
  src/playlistmanager/file/PlaylistFileProvider.h bd19f79 
  src/playlistmanager/file/PlaylistFileProvider.cpp b0ec53a 
  src/playlistmanager/sql/SqlUserPlaylistProvider.h 3a5a62e 
  src/playlistmanager/sql/SqlUserPlaylistProvider.cpp a899843 

Diff: http://git.reviewboard.kde.org/r/100181/diff


Testing
-------

It works fine foe me.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101206/578348a1/attachment.htm