Review Request: Save selected tracks to already saved playlist or a new playlist

Dennis Francis dennisfrancis.in at gmail.com
Wed Dec 1 02:06:25 CET 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100181/
-----------------------------------------------------------

(Updated 2010-12-01 01:06:25.594820)


Review request for Amarok.


Changes
-------

- Extended generatePlaylistName() to accept a custom tracklist
- In case of PlaylistFileProvider, attach the default extension to the path
- Added some debug statements


Summary
-------

Added functionality in the context menu to save the selected tracks ( on the right side ) 

- to a new playlist ( currently only sqlplaylist and fileplaylist providers are only supported )
- into an already existing playlist
  ( Duplication is avoided hence feels like a playlist update )


This addresses bugs 186545, 211811 and 239950.
    https://bugs.kde.org/show_bug.cgi?id=186545
    https://bugs.kde.org/show_bug.cgi?id=211811
    https://bugs.kde.org/show_bug.cgi?id=239950


Diffs (updated)
-----

  src/browsers/playlistbrowser/UserPlaylistModel.cpp 2178d27 
  src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.h e1ae132 
  src/core-impl/collections/mediadevicecollection/playlist/MediaDeviceUserPlaylistProvider.cpp 12d3b46 
  src/core-impl/playlists/providers/user/UserPlaylistProvider.h 609e1a8 
  src/core/playlists/PlaylistFormat.h b93180d 
  src/core/playlists/PlaylistFormat.cpp 6b3cb6b 
  src/core/playlists/PlaylistProvider.h 4cc3417 
  src/core/playlists/PlaylistProvider.cpp 2d37e8b 
  src/playlist/PlaylistDock.h 6e13e7f 
  src/playlist/PlaylistModel.h 3ad8030 
  src/playlist/PlaylistModel.cpp 1acbc9f 
  src/playlist/view/PlaylistViewCommon.h 9582b1b 
  src/playlist/view/PlaylistViewCommon.cpp db300a3 
  src/playlist/view/listview/PrettyListView.h f22a7c8 
  src/playlist/view/listview/PrettyListView.cpp 062c584 
  src/playlistmanager/PlaylistManager.h 943fcf1 
  src/playlistmanager/PlaylistManager.cpp fb13ea7 
  src/playlistmanager/file/PlaylistFileProvider.h bd19f79 
  src/playlistmanager/file/PlaylistFileProvider.cpp 22e8abe 
  src/playlistmanager/sql/SqlUserPlaylistProvider.h 3a5a62e 
  src/playlistmanager/sql/SqlUserPlaylistProvider.cpp d2ae5b9 

Diff: http://git.reviewboard.kde.org/r/100181/diff


Testing
-------

It works fine foe me.


Thanks,

Dennis

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20101201/6a9bfe18/attachment-0001.htm 


More information about the Amarok-devel mailing list