Bugfix amarok crash

[Nanno Langstraat]

On 2010-08-13 21:28, Ralf Engels wrote:
> Hi all,
> the following change seems to fix the Amarok crashes for me.
> Surprisingly.
>    

+1 for this patch, looks good.

Notes:

    * A similar 'containsTrack()' check before the 'subscribeTo()' calls
      in 'insertTracksCommand()' might also be useful?

    * This patch is going to make "remove tracks" agonizingly slow in
      large playlists. O(N*M).


--
However, that performance problem is not this patch's fault, it should 
be fixed by making 'containsTrack()' smarter.

Can be done by maintaining a mapping like:

    //! maps track pointers to playlist items
    QMultiHash<Meta::TrackPtr, Item*> m_TrackToItems;


I happen to have old patches for that, that weren't committed yet when I 
semi-retired. Attached.

They probably won't apply perfectly anymore, but useful for anyone who's 
interested.

     Regards,
     Nanno

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20100814/38f62444/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Playlist-performance-maintain-a-multihash-mapping-Tr.patch
Type: text/x-patch
Size: 0 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100814/38f62444/attachment.patch