[Amarok] 57e87dc Fix Dynamic Collections.

[Jeff Mitchell]

On 08/09/2010 04:32 PM, Maximilian Kossick wrote:
> On Mon, Aug 9, 2010 at 9:56 PM, Ralf Engels <ralf-engels at gmx.de> wrote:
>>
>>> Date: Sun,  8 Aug 2010 22:56:31 +0000 (UTC)
>>> From: Jeff Mitchell <mitchell at kde.org>
>>> Subject: [Amarok] 57e87dc Fix Dynamic Collections.
>>> To: <amarok-devel at kde.org>
>>> Message-ID: <20100808225632.10124B5D1F7 at projects.kde.org>
>>>
>>> commit 57e87dc0139577120a19c0f1c39f5b7fb02b002e
>>> Author: Jeff Mitchell <mitchell at kde.org>
>>> Date:   Sun Aug 8 18:50:39 2010 -0400
>>>
>>>     Fix Dynamic Collections.
>>>
>>>     There were three problems I could find:
>>>
>> ...
>>
>> I realized that there are some additional problems:
>>
>> 1. SqlAlbum::setCompilation
>> when setting an album as a compilation it does not invalidate it.
> 
> nor should it, as its cache is still useable.
> 
>> when setting an album as no compilation it does not invalidate all
>> albums where tracks are getting moved to.
> 
> yep, that's a bug.
> 
>> 2. SqlTrack::setAlbum( const QString &newAlbum )
>> Does not check if the old album is empty and could be removed. This also
>> leaks image cache.
> 
> Album removal should not occur at this stage as the old album object
> is still available from the cache.
> 
>>
>> Also I am pretty sure that I don't want to do a full rescan.
>> Is there some way around this?

I must be missing something. I don't see how these issues are related to
Dynamic Collections.

--Jeff

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20100810/d1400f03/attachment.sig