Testing Needed: Switching enginecontroller to use milliseconds everywhere.

[Mark Kretschmann]

On Wed, Sep 30, 2009 at 6:58 AM, Dan Meltzer
<parallelgrapefruit at gmail.com> wrote:
> Hi Friends,
>
> I got bored this evening and switched enginecontroller::trackLength
> (and Meta::*Track::length() ) to deal internally in milliseconds
> instead of seconds.  This keeps it standard everywhere (and when we
> are ready to display it to users, we can use Meta::msToPrettyTime.
> I've tested most of the changes, but I can't test the media device
> meta stuff (I don't have the media devices to check the collections).
> I also havn't stress tested it completely.  If people that have media
> devices could check out this branch and test it out, that'd be
> awesome.  The branch is in my personal clone (because we can't push
> branches to the main repo apparently..?  That's annoying:
>
> git at gitorious.org:~dmeltzer/amarok/dmeltzers-playground.git
> enginecontroller-milliseconds
>
> If anyone could give it testing, I'll be your friend at least temporarily.

I haven't tested it, but I've reviewed the commits, and it looks
nearly identical to the mythical patch I did before 2.1 (dormant in
some old git-svn repo). Except that my patch wouldn't have applied
cleanly anymore. It would have required a lot of manual tinkering for
merging it in, basically like doing it again from scratch, so I'm glad
that you did that.

As for actual testing, I think the only way to truly test it (apart
from our unit tests) is to get it into mainline master. More exposure,
more eyes on it. I could test your branch, but my own testing would
only get us so far. It needs testing in the wild to really expose
subtle regressions in rarely used code paths.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org