[Amarok] use cached lyrics (if available)

[Seb Ruiz]

2009/9/15 XazZ <devel at xazz.no-ip.info>:
> commit b0a06ac98546cbe0b52e22137333ab76b7433918
> Author:     XazZ <devel at xazz.no-ip.info>
> AuthorDate: Mon Sep 14 23:34:27 2009 +0200
> Commit:     XazZ <devel at xazz.no-ip.info>
> CommitDate: Mon Sep 14 23:38:26 2009 +0200
>
>    use cached lyrics (if available)
>
> diff --git a/src/context/engines/lyrics/LyricsEngine.cpp b/src/context/engines/lyrics/LyricsEngine.cpp
> index d99ceca..a52e026 100644
> --- a/src/context/engines/lyrics/LyricsEngine.cpp
> +++ b/src/context/engines/lyrics/LyricsEngine.cpp
> @@ -120,7 +120,7 @@ void LyricsEngine::update()
>     QString lyrics = currentTrack->cachedLyrics();
>
>     // don't rely on caching for streams
> -    const bool cached = !lyrics.isEmpty() && !The::engineController()->isStream() && ( currentTrack->name() == m_title ) && ( currentTrack->artist()->name() == m_artist );
> +    const bool cached = !lyrics.isEmpty() && !The::engineController()->isStream();

Sorry, how does this fix anything? If anything, it will introduce
false positives. We should never be showing lyrics when there is an
artist and title mismatch.


-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/