[PATCH] (needs review) fix lyrics applet

[Martin]

Hi,

ok, fixing 'some' lyrics issues was not enough for me :)
I was really annoyed by the fact that the lyrics applet
did NOT use system colors. as I'm using the Obisidan Coast
theme I have a dark color scheme - but somehow (not a bug
but a feature ;)) the background of the lyrics applet was
white (SIGH)

there's a bug report about this problem..
https://bugs.kde.org/show_bug.cgi?id=206495

so - I started refactoring the lyrics applet a bit
here's a list of changes that I've made:

* use system colors (FINALLY)
* show that cool spinner (from videoapplet) when a script
  is searching for lyrics
* optimize m_titleText away
* set the title of the applet to "Lyrics : Fetching ..."
  when a script is searching for lyrics (note: this does
  NOT break the string freeze as "Fetching ..." has
  been translated for the videoapplet already)
* removed some unused code
* tiny code cleanup

if you disagree with my coding style please feel free to
inform me what I should change :)

this patch needs testing before it can be pushed into
any stable branch! so you better don't put it in 2.2 ;)

PS: I'll try to seperate the color fix from all other changes
so maybe that part of the patch can go into 2.2
(if it's stable enough)

Regards,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: amarok-fix_lyrics_applet.patch
Type: text/x-diff
Size: 8996 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20090914/3d29a8a1/attachment.bin