Patch review request, Amarok::(Time)Slider

[Seb Ruiz]

2009/10/29 Thomas Lübking <thomas.luebking at web.de>:
> The patch does
>
> a) avoid unnecessary/doub
> le updates/repaints
> b) clip the repainting to the necessary area
>
> Rerason:
> Every repaint will cause a damage event, thus on OpenGL composited desktops a
> pixmap -> texture conversion (what is expensive and scales with the region)  -
> even if there's no visual update in large areas or at all
>
> c) explicitly close painters (on some compilers/optimizations the stack
> deletion can happen with a large delay, what can lead to unbalanced painting
> states and therefore glitches)
>
> d) pass the sliderknob geometry and position calculation to the SvgHandler
> (where the slider is now painted)
>        Before the style was invoked for these calculations what lead at best
> accidental success and would fail if the current widget style sliderhandle
> dimensions differed from the Amarok::Slider assumptions (i.e. e.g. if the knob
> width was >> the slider height) - this leads to "judder" even for small
> differences
>
> e) correct the knobrect calculation by taking the knobs padding (i.e. the half
> width) into account and distributing it over the entire slider width rather
> than having some corner case exceptions (leading to a stick -> jump behaviour)
>

Hi Thomas,
Could you sign up to gitorious.org, apply your patch and create a
merge request? It's simpler for us and more likely that your patch
will be accepted.

-- 
Seb Ruiz

http://www.sebruiz.net/
http://amarok.kde.org/