[PATCH] Font color fixes with partly inverted color schemes

Mark Kretschmann kretschmann at kde.org
Sun Oct 25 17:01:59 CET 2009


On Sun, Oct 25, 2009 at 3:44 PM, Michael Reiher <redm at gmx.de> wrote:
> The attached patch fixes font colors with partly inverted color schemes. That
> means you have for instance a dark window background with a light window
> foreground, however a light view background with a dark view foreground. The
> problem is now that Amarok uses the window background color (dark) to paint
> view type widgets, but uses the view foreground color (also dark) to paint the
> text. This gives dark fonts on dark background, which means reduced
> readability ;) So the patch changes this to use the appropriate window
> foreground color.
>
> The other part of the change concerns hovered tree items. Their background
> color is shaded with the highlight color, however the foreground color is not
> set accordingly.

Michael, the patch does strange things with the text color when
hovering over an item with my default color scheme. It's now white
instead of black, causing readability issues,.

I'm attaching two screenshots that illustrate the problem, first old,
then new. See the topmost item of the playlist on the right side.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: highlight_color_old.png
Type: image/png
Size: 91409 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20091025/14aa56ea/attachment-0002.png 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: highlight_color_new.png
Type: image/png
Size: 93426 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/amarok-devel/attachments/20091025/14aa56ea/attachment-0003.png 


More information about the Amarok-devel mailing list