[Amarok] Remaining time of track could get cut off for very

Mark Kretschmann kretschmann at kde.org
Wed Oct 21 10:41:26 CEST 2009


On Wed, Oct 21, 2009 at 10:31 AM, Seb Ruiz <ruiz at kde.org> wrote:
> 2009/10/21 Mark Kretschmann <kretschmann at kde.org>:
>> +    void setNomWidth( int nomWidth )
>> +    {
>> +        if( nomWidth > 0 )
>> +        {
>> +            m_nomWidth = nomWidth;
>> +            QWidget::setFixedWidth( m_nomWidth );
>> +        }
>> +    }
>> +
>> +    int nomWidth() const
>> +    {
>> +        return m_nomWidth;
>> +    }
>> +
>>  private:
>>     bool m_showTime;
>> +    int  m_nomWidth;
>>
>>  };
>
> After mentioning the "cryptic methods" on the mailing list, these
> should at a very minimum be renamed to nominalWidth() and
> setNominalWidth().

After decoding the "cryptic methods" you could go ahead and commit it
too. I was still guessing what it could mean.

nomnomnomWidth, yum.

-- 
Mark Kretschmann
Amarok Developer
www.kde.org - amarok.kde.org


More information about the Amarok-devel mailing list